]> dgit.raspbian.org Git - gnome-shell.git/commit
popupMenu: Connect after to item 'activate' signal
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Mon, 27 May 2019 19:45:12 +0000 (14:45 -0500)
committerMarco Trevisan (Treviño) <mail@3v1n0.net>
Wed, 29 May 2019 17:04:26 +0000 (12:04 -0500)
commit759120b95fd8cff4f76cceeeeadc404ae51c352d
treef9b0798e3152539970a0fdb700451cb26cf5ba28
parentde0e21612c89d55e8833cb0d321ffc1c5e35fe3f
popupMenu: Connect after to item 'activate' signal

A menu item activation might lead to a call to `itemActivated` which eventually
will close the menu which leads to a `PopupMenu.removeAll` that destroys all the
items, stopping the emission of the 'activate' signal for them.

Before commit 4258ae3e this was not happening because destroy'ing a javascript
object wasn't really disposing it and thus stopping the signal emissions.

So, ensure that `itemActivated` is called after that all the other callbacks
have been consumed, and so that the menu is closed as last thing.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1326

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/557
js/ui/popupMenu.js